Build succeeded.

• containerd-build-arm64 : FAILURE in 2m 00s (non-voting)

LGTM

Codecov Report

Merging #3278 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #3278   +/-   ##
======================================
  Coverage    44.4%   44.4%           
======================================
  Files         113     113           
  Lines       12231   12231           
======================================
  Hits         5431    5431           
  Misses       5966    5966           
  Partials      834     834

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad8848...a6a888c. Read the comment docs.

@crosbymichael @estesp do you plan on shipping a release with this change soon? Since it fixes a socket leak, we would like to get the fix in our systems as soon as possible. Thanks!

#3316 opened to fix release/1.2 for a future 1.2.x release

We have a small issue backporting to release/1.1 as we basically need a "custom" version of ttrpc from the stevvooe/ttrpc era that still uses containerd/log and specifically log.L. format logging. Otherwise we are editing a vendor/ file to make it build, which of course will not pass CI and shouldn't due to direct modification of vendor/ content. Do we make a branch of containerd/ttrpc for this?

@yulianedyalkova we should be preparing a 1.2.7 soon with several fixes that will include this as well. Are you on a 1.2.x release?

@estesp thank you, sounds good! Yes, we are currently using 1.2.6.