Improve ARM platform matching#3270
Merged
estesp merged 1 commit intocontainerd:masterfrom May 10, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3270 +/- ##
=========================================
- Coverage 44.53% 44.4% -0.14%
=========================================
Files 113 113
Lines 12195 12231 +36
=========================================
Hits 5431 5431
- Misses 5930 5966 +36
Partials 834 834
Continue to review full report at Codecov.
|
Member
|
LGTM |
This commit improves ARM platform matching in two instances: * Some old kernels reported the CPU architecture of arm64 cpus as Aarch64 [1]. * In cases where the user is running with armv8 cpu and kernel but amrhf user land (so armhf containerd), a possibility given the compatibility of armv8 with armv7. [1] https://elixir.bootlin.com/linux/v3.14.29/source/arch/arm64/kernel/setup.c#L420 Signed-off-by: Jaime Caamaño Ruiz <jcaamano@suse.com>
Contributor
Author
|
Actually, transitively compatible with amrv6 and armv5 as well. |
Member
|
do we need similar changes in the dockerd code as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit improves ARM platform matching in two instances:
Aarch64 [1].
user land (so armhf containerd), a possibility given the compatibility
of armv8 with armv7.
[1] https://elixir.bootlin.com/linux/v3.14.29/source/arch/arm64/kernel/setup.c#L420
Signed-off-by: Jaime Caamaño Ruiz jcaamano@suse.com