Skip to content

Requeue events in the ttrpc publisher#3207

Merged
estesp merged 2 commits intocontainerd:masterfrom
crosbymichael:ttrpc-deps
Apr 12, 2019
Merged

Requeue events in the ttrpc publisher#3207
estesp merged 2 commits intocontainerd:masterfrom
crosbymichael:ttrpc-deps

Conversation

@crosbymichael
Copy link
Member

@crosbymichael crosbymichael commented Apr 11, 2019 •
edited
Loading

Closes #3177

@crosbymichael
Rename hrpc to tcpServer
97d247c 
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
@crosbymichael crosbymichael added this to the 1.3 milestone Apr 11, 2019
Random-Liu
Random-Liu reviewed Apr 11, 2019
View reviewed changes
@crosbymichael
Requeue events in the shim publisher
63c7a87 
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
@codecov-io
Copy link

codecov-io commented Apr 12, 2019

Codecov Report

Merging #3207 into master will decrease coverage by 4.18%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3207      +/-   ##
==========================================
- Coverage   48.81%   44.63%   -4.19%     
==========================================
  Files         102      113      +11     
  Lines        9538    12161    +2623     
==========================================
+ Hits         4656     5428     +772     
- Misses       4056     5898    +1842     
- Partials      826      835       +9
Flag Coverage Δ
#linux 48.65% <0%> (-0.16%) ⬇️
#windows 39.86% <0%> (?)
Impacted Files Coverage Δ
runtime/v2/shim/publisher.go 0% <0%> (ø) ⬆️
services/server/server.go 1.25% <0%> (-0.3%) ⬇️
snapshots/native/native.go 43.04% <0%> (-9.99%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/tar.go 43.79% <0%> (-7.07%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 57.84% <0%> (-6.36%) ⬇️
content/local/store.go 49.51% <0%> (-5.15%) ⬇️
metadata/images.go 57.57% <0%> (-4.99%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f4c977...63c7a87. Read the comment docs.

@Random-Liu
Copy link
Member

Random-Liu commented Apr 12, 2019

LGTM

estesp
estesp approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 906e8bc into containerd:master Apr 12, 2019
@crosbymichael crosbymichael deleted the ttrpc-deps branch April 12, 2019 17:52
@Random-Liu Random-Liu mentioned this pull request Apr 12, 2019
Merged
@bergwolf bergwolf mentioned this pull request Apr 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Random-Liu Random-Liu Random-Liu left review comments

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.3

Development

Successfully merging this pull request may close these issues.

Containers can't be stopped because TaskExit event failed to be published for runc.v2.

4 participants

@crosbymichael @codecov-io @Random-Liu @estesp