Use ttrpc in the daemon for event publishing from shims#3195
Use ttrpc in the daemon for event publishing from shims#3195estesp merged 2 commits intocontainerd:masterfrom
Conversation
|
We can test but hold off on this for a bit @stevvooe and I are talking about ways to make protobuild do this for us |
runtime/v2/shim/shim_windows.go
Outdated
There was a problem hiding this comment.
Why do we need a retry look for this? On this side the containerd daemon is serving the listener so a connect should always be expected to work instantly right?
There was a problem hiding this comment.
containerd is serving this so it should always work
There was a problem hiding this comment.
I guess I mean why cant this code just say:
return winio.DialPipe(address, &timeout)Like it does for unix?
|
@jhowardmsft - PTAL. |
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
3e86da1 to
0369efe
Compare
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
0369efe to
a6f587e
Compare
|
Good to review now |
Codecov Report
@@ Coverage Diff @@
## master #3195 +/- ##
==========================================
+ Coverage 45.24% 49.29% +4.04%
==========================================
Files 111 100 -11
Lines 11996 9446 -2550
==========================================
- Hits 5428 4656 -772
+ Misses 5733 3964 -1769
+ Partials 835 826 -9
Continue to review full report at Codecov.
|
|
@crosbymichael - Thanks again for doing this! |
|
It seems that this completely broke the containerd Kubernetes e2e test:
|
Instead of the current re-exec, where the shims are required to call back to the main containerd daemon to publish events, this uses a ttrpc server in the main daemon that the shim's can connect to so that they still get a socket to the daemon but not the grpc overhead.