Codecov Report

Merging #3173 into master will increase coverage by 4.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3173      +/-   ##
==========================================
+ Coverage   45.24%   49.26%   +4.02%     
==========================================
  Files         111      100      -11     
  Lines       11978     9426    -2552     
==========================================
- Hits         5419     4644     -775     
+ Misses       5725     3957    -1768     
+ Partials      834      825       -9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4edc733...de1da8b. Read the comment docs.

LGTM

However I think the Wrapf approach is probably better. Please test that and open a PR to do that if you find it works. When you output (.Error()) with wrap it will also add the error messages of the wrapped error at the end just like done here, however it also allows the caller to get the typed error through Cause.

Just catching up on this, will test with Wrapf next week when I’m back in the office. Thanks for the tidy up on the original @crosbymichael