Skip to content

[release/1.2] 1.2.2 release#2917

Merged
dmcgowan merged 1 commit intocontainerd:release/1.2from
dmcgowan:release-1.2.2
Jan 8, 2019
Merged

[release/1.2] 1.2.2 release#2917
dmcgowan merged 1 commit intocontainerd:release/1.2from
dmcgowan:release-1.2.2

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan commented Jan 7, 2019

Add release notes, update version, and add Mike's new email to mailmap

ping @Random-Liu @crosbymichael for release note review

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Jan 7, 2019

LGTM

Random-Liu
Random-Liu reviewed Jan 7, 2019
View reviewed changes
releases/v1.2.2.toml Outdated
Copy link
Copy Markdown
Member

@Random-Liu Random-Liu Jan 7, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action Required: For Kubernetes support, when upgrading containerd from 1.2.0 (including rc releases) to 1.2.1+, a node reboot is recommended to avoid a known deadlock issue in 1.2.0 containerd/cri#1018.

Please reword if you have better suggestion. :)

Copy link
Copy Markdown
Member Author

@dmcgowan dmcgowan Jan 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, it will come out looking like this https://gist.github.com/dmcgowan/c9108f1c2f3d12cc6d008a105a61b843

andrewhsu
andrewhsu approved these changes Jan 7, 2019
View reviewed changes
Copy link
Copy Markdown

@andrewhsu andrewhsu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w.r.t. words for FIFO fix

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 7, 2019 •
edited
Loading

Codecov Report

Merging #2917 into release/1.2 will decrease coverage by 3.67%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.2    #2917      +/-   ##
===============================================
- Coverage        47.41%   43.74%   -3.68%     
===============================================
  Files               91      100       +9     
  Lines             8410    10728    +2318     
===============================================
+ Hits              3988     4693     +705     
- Misses            3699     5305    +1606     
- Partials           723      730       +7
Flag Coverage Δ
#linux 47.41% <ø> (ø) ⬆️
#windows 40.9% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.3% <0%> (-10%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/tar.go 43.13% <0%> (-6.87%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 57.84% <0%> (-6.36%) ⬇️
content/local/store.go 48.51% <0%> (-5.03%) ⬇️
remotes/docker/resolver.go 58.36% <0%> (-4.99%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
metadata/images.go 58.46% <0%> (-4.7%) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bb2b0c...ef63704. Read the comment docs.

@dmcgowan
Update for 1.2.2 release
ef63704 
Add release notes, update version, and add Mike's new email to mailmap

Signed-off-by: Derek McGowan <derek@mcgstyle.net>
@Random-Liu
Copy link
Copy Markdown
Member

Random-Liu commented Jan 7, 2019

LGTM

@dmcgowan dmcgowan merged commit 9754871 into containerd:release/1.2 Jan 8, 2019
@dmcgowan dmcgowan deleted the release-1.2.2 branch September 10, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Random-Liu Random-Liu Random-Liu left review comments

@crosbymichael crosbymichael Awaiting requested review from crosbymichael

+1 more reviewer

@andrewhsu andrewhsu andrewhsu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dmcgowan @crosbymichael @codecov-io @Random-Liu @andrewhsu