Skip to content

[release/1.2] Revert "Fix CI due to Golang 1.10.6 / 1.11.3 regressions (workaround)"#2893

Merged
crosbymichael merged 1 commit intocontainerd:release/1.2from
thaJeztah:1.2_revert_temp_golang_fix
Dec 19, 2018
Merged

[release/1.2] Revert "Fix CI due to Golang 1.10.6 / 1.11.3 regressions (workaround)"#2893
crosbymichael merged 1 commit intocontainerd:release/1.2from
thaJeztah:1.2_revert_temp_golang_fix

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

This reverts commit 27c6449 (#2881)

Golang 1.10.7 and 1.11.4 have been released, which address the regression, so we no longer need this temporary workaround

This reverts commit 27c6449.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 46e6333 into containerd:release/1.2 Dec 19, 2018
@thaJeztah thaJeztah deleted the 1.2_revert_temp_golang_fix branch December 19, 2018 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants