Skip to content

Fix CI due to Golang 1.10.6 / 1.11.3 regressions (workaround)#2879

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
thaJeztah:fix_ci_golang_1.11
Dec 14, 2018
Merged

Fix CI due to Golang 1.10.6 / 1.11.3 regressions (workaround)#2879
crosbymichael merged 1 commit intocontainerd:masterfrom
thaJeztah:fix_ci_golang_1.11

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Dec 14, 2018 •
edited
Loading

Attempt to fix CI is failing due to a regression in Go 1.10.6 / 1.11.3 (see golang/go#29241)

package github.com/containernetworking/plugins/...: github.com/containernetworking/plugins/...: invalid import path: malformed import path "github.com/containernetworking/plugins/...": double dot

@thaJeztah thaJeztah mentioned this pull request Dec 14, 2018
Merged
@thaJeztah thaJeztah changed the title Fix CI due to Golang 1.11.3 regressions (workaround) Fix CI due to Golang 1.10.6 / 1.11.3 regressions (workaround) Dec 14, 2018
@thaJeztah
Fix CI due to Golang 1.10.6 / 1.11.3 regressions (workaround)
52de371 
Attempt to fix CI is failing due to a regression in Go 1.10.6 / 1.11.3 (see golang/go#29241)

```
package github.com/containernetworking/plugins/...: github.com/containernetworking/plugins/...: invalid import path: malformed import path "github.com/containernetworking/plugins/...": double dot
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Dec 14, 2018

Whoop! That fixed it. Pushing one small change to add a "TODO" / "FIXME" in the Makefile, so that we don't forget

screen shot 2018-12-14 at 15 33 59

This was referenced Dec 14, 2018
Merged
Merged
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Dec 14, 2018 •
edited
Loading

ping @crosbymichael @andrewhsu @estesp PTAL

@thaJeztah thaJeztah mentioned this pull request Dec 14, 2018
Closed
estesp
estesp approved these changes Dec 14, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 14, 2018

Codecov Report

Merging #2879 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2879   +/-   ##
=======================================
  Coverage   43.89%   43.89%           
=======================================
  Files         101      101           
  Lines       10800    10800           
=======================================
  Hits         4741     4741           
  Misses       5328     5328           
  Partials      731      731
Flag Coverage Δ
#linux 47.5% <ø> (ø) ⬆️
#windows 41.07% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc06a65...52de371. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Dec 14, 2018

LGTM

@crosbymichael crosbymichael merged commit 121d48a into containerd:master Dec 14, 2018
@thaJeztah thaJeztah deleted the fix_ci_golang_1.11 branch December 14, 2018 15:15
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Dec 15, 2018

Looks like we can revert this one once the new version is up on Docker Hub

Hello gophers,

We have just released Go versions 1.11.4 and 1.10.7, minor point releases.

These releases include fixes to cgo, the compiler, linker, runtime,
documentation, go command, and the net/http and go/types packages.
They include a fix to a bug introduced in Go 1.11.3 and Go 1.10.6
that broke "go get" for import path patterns containing "...".

View the release notes for more information:
   https://golang.org/doc/devel/release.html#go1.11.minor

You can download binary and source distributions from the Go web site:
   https://golang.org/dl/

To compile from source using a Git clone, update to the release with
"git checkout go1.11.4" and build as usual.

Thanks to everyone who contributed to the release.

Alla prossima,
Filippo for the Go team

@thaJeztah thaJeztah mentioned this pull request Dec 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @codecov-io @crosbymichael @estesp