Skip to content

Rootless mode #2766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crosbymichael merged 2 commits into from
Nov 7, 2018
Merged

Rootless mode #2766

crosbymichael merged 2 commits into from
Nov 7, 2018

Conversation

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Nov 6, 2018 •
edited
Loading

  • ctr: add --cgroup for oci.WithCgroup
  • add docs/rootless.md

No change on the daemon side at all. (CRI plugin will support "cgroupless" configuration in a separate PR)

Replaces #2006
Closes #2262
Relates to moby/moby#38050

This was referenced Nov 6, 2018
Closed
Closed
AkihiroSuda
AkihiroSuda commented Nov 6, 2018
View reviewed changes
docs/rootless.md Outdated
Copy link
Member Author

@AkihiroSuda AkihiroSuda Nov 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example of this is v2 runtime:
#2767

@AkihiroSuda
ctr: add --cgroup for oci.WithCgroup
dd0539b 
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
@AkihiroSuda
add docs/rootless.md
ce6d4c9 
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
@codecov-io
Copy link

codecov-io commented Nov 6, 2018 •
edited
Loading

Codecov Report

Merging #2766 into master will decrease coverage by 3.67%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2766      +/-   ##
==========================================
- Coverage   47.39%   43.72%   -3.68%     
==========================================
  Files          91      100       +9     
  Lines        8415    10734    +2319     
==========================================
+ Hits         3988     4693     +705     
- Misses       3704     5311    +1607     
- Partials      723      730       +7
Flag Coverage Δ
#linux 47.39% <ø> (ø) ⬆️
#windows 40.89% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.3% <0%> (-10%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/tar.go 43.13% <0%> (-6.87%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 57.84% <0%> (-6.36%) ⬇️
content/local/store.go 48.51% <0%> (-5.03%) ⬇️
remotes/docker/resolver.go 58.36% <0%> (-4.99%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
metadata/images.go 58.46% <0%> (-4.7%) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dcabd6...ce6d4c9. Read the comment docs.

estesp
estesp approved these changes Nov 7, 2018
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Member

crosbymichael commented Nov 7, 2018

LGTM

@crosbymichael crosbymichael merged commit 8e6cf4f into containerd:master Nov 7, 2018
@cyphar
Copy link
Contributor

cyphar commented Nov 8, 2018

Awesome!

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Nov 9, 2018

PR for CRI plugin: containerd/cri#970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AkihiroSuda @codecov-io @crosbymichael @cyphar @estesp