Skip to content

Add optional install path#2630

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael:install-path
Sep 11, 2018
Merged

Add optional install path#2630
crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael:install-path

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

This allows users to consume the install functionality but also install
to other areas instead of the managed /opt dir.

> ctr install --path /usr/local

Signed-off-by: Michael Crosby crosbymichael@gmail.com

This allows users to consume the install functionality but also install
to other areas instead of the managed `/opt` dir.

```bash
> ctr install --path /usr/local
```

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
@estesp
Copy link
Copy Markdown
Member

estesp commented Sep 11, 2018

You just can't win with CI on this one...give up all hope now.

@crosbymichael
Copy link
Copy Markdown
Member Author

Things were acting weird last night, not getting the CI status in other projects and now on containerd today. Not sure what's up.

@estesp
Copy link
Copy Markdown
Member

estesp commented Sep 11, 2018

Travis had some sort of outage yesterday and I think things are taking a while to settle back to normal

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 11, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@ed2bf6d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2630   +/-   ##
=========================================
  Coverage          ?   47.77%           
=========================================
  Files             ?       87           
  Lines             ?     8153           
  Branches          ?        0           
=========================================
  Hits              ?     3895           
  Misses            ?     3538           
  Partials          ?      720
Flag Coverage Δ
#linux 47.77% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed2bf6d...60d13d6. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehazlett
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 83668f4 into containerd:master Sep 11, 2018
@crosbymichael crosbymichael deleted the install-path branch September 11, 2018 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants