Add With-helper for supplemental gid support#2627
Merged
estesp merged 1 commit intocontainerd:masterfrom Sep 12, 2018
Merged
Conversation
865ec49 to
cfab735
Compare
Codecov Report
@@ Coverage Diff @@
## master #2627 +/- ##
==========================================
- Coverage 44.05% 43.76% -0.29%
==========================================
Files 94 94
Lines 10238 10305 +67
==========================================
Hits 4510 4510
- Misses 5008 5075 +67
Partials 720 720
Continue to review full report at Codecov.
|
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
Can be used to conform to Docker engine behavior of adding additional GIDs to spec when found in /etc/group of image filesystem Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
cfab735 to
78e61af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can be used to conform to Docker engine behavior of adding additional
GIDs to spec when found in /etc/group of image filesystem
Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com