move WithXXXX to task_opts.go#2623
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Sep 10, 2018
Merged
Conversation
8960b08 to
9c64e58
Compare
Member
|
Move looks good, CI caught a gofmt issue though |
cf362c1 to
07f4a52
Compare
Signed-off-by: yanxuean <yan.xuean@zte.com.cn>
07f4a52 to
3c8692a
Compare
Codecov Report
@@ Coverage Diff @@
## master #2623 +/- ##
=======================================
Coverage 44.07% 44.07%
=======================================
Files 94 94
Lines 10232 10232
=======================================
Hits 4510 4510
Misses 5002 5002
Partials 720 720
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yanxuean yan.xuean@zte.com.cn