Fix runc state error handling.#2598
Merged
estesp merged 1 commit intocontainerd:masterfrom Aug 31, 2018
Merged
Conversation
Signed-off-by: Lantao Liu <lantaol@google.com>
Codecov Report
@@ Coverage Diff @@
## master #2598 +/- ##
=======================================
Coverage 44.05% 44.05%
=======================================
Files 98 98
Lines 10130 10130
=======================================
Hits 4463 4463
Misses 4945 4945
Partials 722 722
Continue to review full report at Codecov.
|
Member
|
LGTM |
Member
|
What about fixing |
Member
|
@estesp i think it would be a little more challenging and require some more work to get error codes from runc/parse the output on STDERR and return go level errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error returned by
runtime.Stateis a composed errorfmt.Errorf("%s: %s", err, data). We can't useos.IsNotExistdirectly on it.If the runc container is successfully deleted, but rootfs unmount fails here, we won't be able to load the task and retry deletion again, we'll keep getting:
This is not urgent, because rootfs unmount won't fail in normal cases.
Signed-off-by: Lantao Liu lantaol@google.com