Fix compilation failures on Go 1.11#2487
Merged
estesp merged 1 commit intocontainerd:masterfrom Jul 23, 2018
Merged
Conversation
Compilation failed;
windows\process.go:124: Wrapf format %s has arg s of wrong type github.com/containerd/containerd/runtime.Status
windows\task.go:287: Wrapf format %d has arg id of wrong type string
windows\task.go:300: Wrapf format %d has arg t.id of wrong type string
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Merged
Member
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #2487 +/- ##
=======================================
Coverage 44.76% 44.76%
=======================================
Files 93 93
Lines 9555 9555
=======================================
Hits 4277 4277
Misses 4585 4585
Partials 693 693
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compilation failed;