BUILDING.md: add osusergo for static build#2476
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Jul 19, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2476 +/- ##
=======================================
Coverage 44.73% 44.73%
=======================================
Files 93 93
Lines 9490 9490
=======================================
Hits 4245 4245
Misses 4562 4562
Partials 683 683
Continue to review full report at Codecov.
|
Go 1.11 includes a fix to os/user to be working in a static binary (fixing golang/go#23265). The fix requires `osusergo` build tag to be set for static binaries, which is what this commit documents. [v2: sort tags alphabetically] Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Contributor
Author
|
Also related: moby/moby#37500. |
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.11 includes a fix to os/user to be working in a static binary
(fixing golang/go#23265). The fix requires
osusergobuild tag to be set for static binaries, which is whatthis commit documents.