Skip to content

Set shim max procs via env var#2423

Merged
mlaventure merged 1 commit intocontainerd:masterfrom
crosbymichael:shim-procs
Jun 26, 2018
Merged

Set shim max procs via env var#2423
mlaventure merged 1 commit intocontainerd:masterfrom
crosbymichael:shim-procs

Conversation

@crosbymichael
Copy link
Member

This sets the shim's max procs to 2, like we already have hard coded in
the shim, with the env var so that it is set at go runtime boot.

Signed-off-by: Michael Crosby crosbymichael@gmail.com

This sets the shim's max procs to 2, like we already have hard coded in
the shim, with the env var so that it is set at go runtime boot.

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #2423 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2423   +/-   ##
=======================================
  Coverage   45.03%   45.03%           
=======================================
  Files          92       92           
  Lines        9407     9407           
=======================================
  Hits         4236     4236           
  Misses       4488     4488           
  Partials      683      683
Flag Coverage Δ
#linux 49.26% <ø> (ø) ⬆️
#windows 41.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ac546b...68e144c. Read the comment docs.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mlaventure mlaventure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants