Normalize arm64 to an empty variant#2417
Conversation
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Codecov Report
@@ Coverage Diff @@
## master #2417 +/- ##
==========================================
- Coverage 45.06% 45.03% -0.04%
==========================================
Files 92 92
Lines 9413 9407 -6
==========================================
- Hits 4242 4236 -6
Misses 4488 4488
Partials 683 683
Continue to review full report at Codecov.
|
|
LGTM |
| p.OS = normalizeOS(parts[0]) | ||
| p.Architecture, p.Variant = normalizeArch(parts[1], parts[2]) | ||
| if p.Architecture == "arm64" && p.Variant == "" { | ||
| p.Variant = "v8" |
There was a problem hiding this comment.
So, this sets it to "v8" if its present?
There was a problem hiding this comment.
This sets it to "v8" if it was given as "v8" (or "8"). This Parse function is kind of confusing in that it normalizes the parts but not the whole. Take a look at the test cases I added to make sure it makes sense.
There was a problem hiding this comment.
Diff of both changes in the release backport PR https://github.com/containerd/containerd/pull/2416/files
Updates arm64 normalization to match what is described in https://github.com/golang/go/wiki/GoArm
The output of
Parseshould remain the same, theNormalizefunction should now have an empty variant forarm64.