Conversation
Codecov Report
@@ Coverage Diff @@
## master #2414 +/- ##
==========================================
+ Coverage 44.99% 45.06% +0.06%
==========================================
Files 92 92
Lines 9398 9413 +15
==========================================
+ Hits 4229 4242 +13
- Misses 4486 4488 +2
Partials 683 683
Continue to review full report at Codecov.
|
|
@stevvooe would this be safe to cherry-pick to 1.1.x? |
|
I didn't think a variant was required for arm64. Perhaps, the bug is in https://github.com/containerd/containerd/blob/master/platforms/cpuinfo.go#L84? |
The normalization was being inconsistently applied causing a failure to match some platforms in manifest lists. Fix the matcher and normalization to be more consistent and add changes to parser to prevent the defaulted variants from being set in the platform structure. Signed-off-by: Derek McGowan <derek@mcgstyle.net>
b0ca2dd to
37ab93e
Compare
It is not required. The normalized form will always be specific now and I updated the I updated to handle the |
|
ping @tianon can you take a look as well? |
|
Looks sane to me 👍 |
|
This needs to get reverted. The bug is at https://github.com/containerd/containerd/blob/master/platforms/cpuinfo.go#L84. |
The normalization was being inconsistently applied causing a failure to match some platforms in manifest lists. Fix the matcher and normalization to be more consistent and add changes to parser to prevent the defaulted variants from being set in the platform structure.
Fixes #2409