Move ContainerFlags to "commands" package#2411
Merged
stevvooe merged 1 commit intocontainerd:masterfrom Jun 25, 2018
Merged
Conversation
Commit 0551328 exposed the "rootfs" and "no-pivot" flags for the "containers" command, but it accidentally removed them for "run" since package-level variables are initialized before package-level init functions in golang. Hoisting these flags to a package imported by both commands solves the problem. Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
Codecov Report
@@ Coverage Diff @@
## master #2411 +/- ##
=======================================
Coverage 44.99% 44.99%
=======================================
Files 92 92
Lines 9398 9398
=======================================
Hits 4229 4229
Misses 4486 4486
Partials 683 683
Continue to review full report at Codecov.
|
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 0551328 exposed the "rootfs"
and "no-pivot" flags for the "containers" command, but it accidentally
removed them for "run" since package-level variables are initialized
before package-level init functions in golang. Hoisting these flags to
a package imported by both commands solves the problem.
Signed-off-by: Felix Abecassis fabecassis@nvidia.com