Skip to content

Docs: Fix incomplete instructions for building using docker#2397

Merged
estesp merged 1 commit intocontainerd:masterfrom
harche:doc_fix
Jun 14, 2018
Merged

Docs: Fix incomplete instructions for building using docker#2397
estesp merged 1 commit intocontainerd:masterfrom
harche:doc_fix

Conversation

@harche
Copy link

@harche harche commented Jun 12, 2018

Fixes: #2396

Signed-off-by: Harshal Patil harshal.patil@in.ibm.com

@ehazlett
Copy link
Member

@harche thanks for the contribution! You need to sign your commit according to the DCO.

https://github.com/containerd/containerd/blob/master/CONTRIBUTING.md#sign-your-work

@harche
Copy link
Author

harche commented Jun 13, 2018

@ehazlett Thanks. But I've signed my commit as per DCO. Not sure why it's complaining about it.

@ehazlett
Copy link
Member

ah sorry I saw the DCO fail. this is the issue that is part of the check:

4ec6f96 - FAIL - has whitespace errors. See `git show --check 4ec6f96991feccc55d662046eb6bb2830137fb24`

@estesp
Copy link
Member

estesp commented Jun 13, 2018

@harche the line you added has a trailing space after the package name you added, so it failed the whitespace check. If you remove that extra space and re-push the check will pass.

Fixes: containerd#2396

Signed-off-by: Harshal Patil <harshal.patil@in.ibm.com>
@codecov-io
Copy link

codecov-io commented Jun 13, 2018

Codecov Report

Merging #2397 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2397   +/-   ##
=======================================
  Coverage   44.99%   44.99%           
=======================================
  Files          92       92           
  Lines        9398     9398           
=======================================
  Hits         4229     4229           
  Misses       4486     4486           
  Partials      683      683
Flag Coverage Δ
#linux 49.23% <ø> (ø) ⬆️
#windows 41.26% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0158a6f...ef449aa. Read the comment docs.

@harche
Copy link
Author

harche commented Jun 13, 2018

@estesp Thanks.

@crosbymichael
Copy link
Member

LGTM

1 similar comment
@ehazlett
Copy link
Member

LGTM

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit c1e1f3d into containerd:master Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants