Docs: Fix incomplete instructions for building using docker#2397
Docs: Fix incomplete instructions for building using docker#2397estesp merged 1 commit intocontainerd:masterfrom
Conversation
|
@harche thanks for the contribution! You need to sign your commit according to the DCO. https://github.com/containerd/containerd/blob/master/CONTRIBUTING.md#sign-your-work |
|
@ehazlett Thanks. But I've signed my commit as per DCO. Not sure why it's complaining about it. |
|
ah sorry I saw the DCO fail. this is the issue that is part of the check: |
|
@harche the line you added has a trailing space after the package name you added, so it failed the whitespace check. If you remove that extra space and re-push the check will pass. |
Fixes: containerd#2396 Signed-off-by: Harshal Patil <harshal.patil@in.ibm.com>
Codecov Report
@@ Coverage Diff @@
## master #2397 +/- ##
=======================================
Coverage 44.99% 44.99%
=======================================
Files 92 92
Lines 9398 9398
=======================================
Hits 4229 4229
Misses 4486 4486
Partials 683 683
Continue to review full report at Codecov.
|
|
@estesp Thanks. |
|
LGTM |
1 similar comment
|
LGTM |
Fixes: #2396
Signed-off-by: Harshal Patil harshal.patil@in.ibm.com