Skip to content

Update gotestyourself to gotest.tools#2393

Merged
mlaventure merged 2 commits intocontainerd:masterfrom
vdemeester:gotestyourself-with-tools
Jun 11, 2018
Merged

Update gotestyourself to gotest.tools#2393
mlaventure merged 2 commits intocontainerd:masterfrom
vdemeester:gotestyourself-with-tools

Conversation

@vdemeester
Copy link
Contributor

github.com/gotestyourself/gotestyourself moved to gotest.tools with version 2.0.0. Moving to that one, bumping it to v2.1.0.

🦁

cc @dnephin

github.com/gotestyourself/gotestyourself moved to gotest.tools with
version 2.0.0. Moving to that one, bumping it to v2.1.0.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@codecov-io
Copy link

Codecov Report

Merging #2393 into master will increase coverage by 3.73%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2393      +/-   ##
==========================================
+ Coverage   41.26%   44.99%   +3.73%     
==========================================
  Files          66       92      +26     
  Lines        7850     9398    +1548     
==========================================
+ Hits         3239     4229     +990     
- Misses       4103     4486     +383     
- Partials      508      683     +175
Flag Coverage Δ
#linux 49.23% <ø> (?)
#windows 41.26% <ø> (ø) ⬆️
Impacted Files Coverage Δ
oci/spec_unix.go 98.37% <0%> (ø)
mount/mountinfo_linux.go 53.06% <0%> (ø)
sys/filesys_unix.go 0% <0%> (ø)
sys/reaper.go 0% <0%> (ø)
services/server/server_linux.go 0% <0%> (ø)
mount/temp.go 14.28% <0%> (ø)
sys/epoll.go 0% <0%> (ø)
oci/spec_opts_unix.go 21.77% <0%> (ø)
sys/fds.go 0% <0%> (ø)
cio/io_unix.go 74.71% <0%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35887db...832b05a. Read the comment docs.

Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlaventure mlaventure merged commit 0158a6f into containerd:master Jun 11, 2018
@vdemeester vdemeester deleted the gotestyourself-with-tools branch June 11, 2018 15:17
@crosbymichael
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants