Conversation
|
@andrewosh thanks for the PR. You need to sign your commit according to the DCO before we can merge. https://github.com/containerd/containerd/blob/master/CONTRIBUTING.md#sign-your-work |
Signed-off-by: Andrew Osheroff <andrewosh@gmail.com>
Signed-off-by: Andrew Osheroff <andrewosh@gmail.com>
|
Thanks for your PR! Are you able to sign the commit and re-push? Let us know if you need help. |
|
Ah! Hey @estesp -- ya know, a pesky unsigned merge commit sneaked in, and it's mucking things up. I don't want to waste your time (on a one-word typo fix!) -- feel free to close this and fix the typo yourself :) If possible, I'd suggest that the commit validator ignore merge commits, as there shouldn't be a need to sign those if the commits-to-merge are signed. |
|
Yeah, I don't know if that is from using the built-in GitHub tooling, but at the command line doing a |
No description provided.