Tweak mount info for overlayfs in case of parallel unpack#13115
Merged
Conversation
Signed-off-by: Henry Wang <henwang@amazon.com>
Signed-off-by: Henry Wang <henwang@amazon.com>
fuweid
approved these changes
Mar 25, 2026
Member
|
/cherrypick release/2.2 |
|
@samuelkarp: new pull request created: #13125 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
AkihiroSuda
reviewed
May 12, 2026
| m.Options = append(m.Options, o) | ||
| } | ||
| } | ||
| m.Options = append(m.Options, "upperdir="+mounts[0].Source) |
Member
There was a problem hiding this comment.
How does this work without specifying lowerdir?
$ sudo mount -t overlay -o ro,upperdir=/tmp/foo overlay /tmp/bar/
mount: /tmp/bar: wrong fs type, bad option, bad superblock on overlay, missing codepage or helper program, or other error.
dmesg(1) may have more information after failed mount system call.
$ sudo dmesg
[...]
[ 3499.690103] overlayfs: missing 'lowerdir'
Member
Author
There was a problem hiding this comment.
It relies on the following logic in the applier:
containerd/core/diff/apply/apply_linux.go
Lines 36 to 59 in a275642
This code path does not perform actual fs mount.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #13030
Alternative to: #13044
Instead of changing overlay snapshotter itself, this PR updates unpacker logic to tweak the mount info returned by overlay in the parallel case.