CNI DEL not issued on certain conditions#12922
Closed
MikeZappa87 wants to merge 1 commit into
Closed
Conversation
e14d094 to
127872f
Compare
when a higher version of drop in config is used than the root containerd config, do not load the config. When config is merged, the higher version takes precedence preventing the root config from getting migrated to the newer version. Signed-off-by: Akhil Mohan <akhilerm@gmail.com> Signed-off-by: Michael Zappa <michael.zappa@gmail.com>
6ffacea to
75361f3
Compare
75361f3 to
81a1a55
Compare
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This was referenced Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have seen a condition, where the CNI ADD is executed, and containerd exits before the cniResult is saved to disk. When containerd recoverys the StopPodSandbox is called, but skips the CNI DEL because the CNI result is nil. The idea here is to ignore errors from the CNI DEL and try to do a best effort cleanup. The alternative is that a leaked resource could still exist which has been observed.
We see the RunPodSandbox + StopPodSandbox RPC's executed, just no CNI DEL cmd is viewed.