[release/1.7] go.mod: golang.org/x/crypto v0.45.0 (drop support for Go 1.23) #12640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Sorry, can you rebase on |
corhere
approved these changes
Dec 8, 2025
akhilerm
reviewed
Dec 9, 2025
| module github.com/containerd/containerd | ||
|
|
||
| go 1.23.0 | ||
| go 1.24.0 |
Member
There was a problem hiding this comment.
There was an earlier discussion on changing the minimum go version on an existing release branch and we didnt want to do this bump cc: @thaJeztah
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
It is fine since 1.23 is not in support and this is a transitive requirement. So if we accept the v0.45.0 version, we are also accepting the 1.24 minimum.
Member
There was a problem hiding this comment.
Discussed with Mike on this, updating the minimum version will be the best way forward.
Updates BUILDING.md to specify that the project supports the two most recent major Go versions, rather than hardcoding "1.22.x or above" (as we don't support 1.22). This ensures the documentation doesn't become outdated when new Go versions are released. Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com> (cherry picked from commit fb28794) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
dmcgowan
approved these changes
Dec 9, 2025
akhilerm
approved these changes
Dec 9, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silence the following govulncheck reports
("you import and 3 vulnerabilities in modules you require, but your code doesn't appear to call these vulnerabilities"):
This commit also drops the support for Go 1.23, and cherry-picks: