Skip to content

[release/2.1] go.mod: golang.org/x/crypto v0.45.0 (drop support for Go 1.23) #12639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
estesp merged 3 commits into from
Dec 8, 2025
Merged

[release/2.1] go.mod: golang.org/x/crypto v0.45.0 (drop support for Go 1.23) #12639

estesp merged 3 commits into from
Dec 8, 2025

Conversation

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Dec 8, 2025

Silence the following govulncheck reports
("you import and 3 vulnerabilities in modules you require, but your code doesn't appear to call these vulnerabilities"):

Vulnerability #1: GO-2025-4135
    Malformed constraint may cause denial of service in
    golang.org/x/crypto/ssh/agent
  More info: https://pkg.go.dev/vuln/GO-2025-4135
  Module: golang.org/x/crypto
    Found in: golang.org/x/crypto@v0.41.0
    Fixed in: golang.org/x/crypto@v0.45.0

Vulnerability #2: GO-2025-4134
    Unbounded memory consumption in golang.org/x/crypto/ssh
  More info: https://pkg.go.dev/vuln/GO-2025-4134
  Module: golang.org/x/crypto
    Found in: golang.org/x/crypto@v0.41.0
    Fixed in: golang.org/x/crypto@v0.45.0

Vulnerability #3: GO-2025-4116
    Potential denial of service in golang.org/x/crypto/ssh/agent
  More info: https://pkg.go.dev/vuln/GO-2025-4116
  Module: golang.org/x/crypto
    Found in: golang.org/x/crypto@v0.41.0
    Fixed in: golang.org/x/crypto@v0.43.0

This commit also drops the support for Go 1.23, and cherry-picks:

mxpv and others added 2 commits December 8, 2025 13:27
@mxpv @AkihiroSuda
Update Go requirements in BUILDING
fd8e3c3 
Updates BUILDING.md to specify that the project supports the two most recent major Go versions,
rather than hardcoding "1.22.x or above" (as we don't support 1.22).

This ensures the documentation doesn't become outdated when new Go versions are released.

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
(cherry picked from commit fb28794)
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
CI: drop Go 1.23
55a2d8c 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@github-project-automation github-project-automation bot moved this to Needs Triage in Pull Request Review Dec 8, 2025
@dosubot dosubot bot added the dependencies Pull requests that update a dependency file label Dec 8, 2025
@AkihiroSuda
go.mod: golang.org/x/crypto v0.45.0
e816788 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
mikebrow
mikebrow approved these changes Dec 8, 2025
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from Needs Triage to Review In Progress in Pull Request Review Dec 8, 2025
@estesp estesp merged commit 7c4efcb into containerd:release/2.1 Dec 8, 2025
51 checks passed
@github-project-automation github-project-automation bot moved this from Review In Progress to Done in Pull Request Review Dec 8, 2025
@dmcgowan dmcgowan mentioned this pull request Dec 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file size/XXL

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AkihiroSuda @estesp @mikebrow @k8s-ci-robot @mxpv