[release/2.2] core/runtime/v2: remove uses of otelgrpc.UnaryClientInterceptor #12622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
does the bot have an option to do the rebase or does that have to be done by someone with write access? |
Member
there is a update (PR) with rebase option in the GitHub client.. but that's probably because I have merge rights.... would you like me to rebase? |
Member
|
Oh, looks like that shows for me as well; I can try |
The otelgrpc.UnaryClientInterceptor and otelgrpc.StreamClientInterceptor options were deprecated and removed in favor of NewClientHandler. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2ee87dd to
ed19c54
Compare
Member
cool so write or commit owner |
Member
|
Yeah, I guess I may have write access, but (as reviewer / non-committer) not permissions to merge / add to merge queue. Good to see it worked 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #12606
/assign thaJeztah