-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[release/2.2] Update runc binary to v1.3.4 #12593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @@ -1 +1 @@ | |||
| v1.3.3 | |||
| v1.3.4 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since runc v1.4.0 is available , we should be switching to that version in main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, I've switched this one to target the 2.2 release branch
This update includes a fix for a regression introduced in CVE-2025-52881 mitigation patches where the `mode=` argument was incorrectly applied to tmpfs mounts regardless of whether the target path existed. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
|
That CI is passing I think validates this, but 1.4.0 has a breaking change regarding the handling of |
|
@samuelkarp the 1.4 change was merged in main, should we create an issue to make sure we are testing that case? Are you ok getting this 1.3.4 change, I don't think we have had much runc version skew between main and release branches but it seems warranted in this case. |
I need to get my eyes checked 👀. I think 1.4 is fine in the release branches as long as we've validated that our spec generation logic doesn't populate 0 when we mean unset (which I don't think it does...I think we're in the clear). Opened #12607 for tracking. |
|
I hope containerd LTS 1.7 will add support for the runc 1.3.4 binary soon right? |
It is already supported, runc can be updated independently of containerd. This is for our own testing and the Github release tars but packagers can choose their own version. |
|
/cherry-pick release/2.1 |
|
@dmcgowan: new pull request created: #12618 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release/1.7 |
|
@dmcgowan: new pull request created: #12619 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This update includes a fix for a regression introduced in CVE-2025-52881 mitigation patches where the
mode=argument was incorrectly applied to tmpfs mounts regardless of whether the target path existed.