Skip to content

Conversation

@klihub
Copy link
Member

@klihub klihub commented Nov 25, 2025

Skip processing early if we get a nil adjustment from NRI instead of going through the motions.

@klihub klihub requested a review from mikebrow November 25, 2025 08:30
@github-project-automation github-project-automation bot moved this to Needs Triage in Pull Request Review Nov 25, 2025
@dosubot dosubot bot added the area/nri Node Resource Interface (NRI) label Nov 25, 2025
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow added cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch cherry-pick/2.1.x Change to be cherry picked to release/2.1 branch cherry-pick/2.2.x Change to be cherry picked to release/2.2 branch and removed cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch labels Nov 25, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Review In Progress in Pull Request Review Nov 25, 2025
@mxpv mxpv added this pull request to the merge queue Nov 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 25, 2025
@mxpv mxpv added this pull request to the merge queue Nov 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 25, 2025
@samuelkarp samuelkarp added this pull request to the merge queue Nov 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2025
@AkihiroSuda AkihiroSuda added this pull request to the merge queue Nov 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2025
@AkihiroSuda AkihiroSuda added this pull request to the merge queue Nov 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2025
@mxpv mxpv added this pull request to the merge queue Nov 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2025
Skip processing early if we get a nil adjustment from NRI.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub klihub force-pushed the devel/short-circuit-nil-adjustment branch from 1039c16 to 3a717c1 Compare November 27, 2025 14:41
@mikebrow mikebrow added this pull request to the merge queue Nov 27, 2025
Merged via the queue into containerd:main with commit e3ec509 Nov 27, 2025
90 of 92 checks passed
@github-project-automation github-project-automation bot moved this from Review In Progress to Done in Pull Request Review Nov 27, 2025
@klihub klihub deleted the devel/short-circuit-nil-adjustment branch December 4, 2025 09:14
@austinvazquez
Copy link
Member

/cherry-pick release/2.2

@k8s-infra-cherrypick-robot

@austinvazquez: new pull request created: #12672

Details

In response to this:

/cherry-pick release/2.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@austinvazquez
Copy link
Member

/cherry-pick release/2.1

@k8s-infra-cherrypick-robot

@austinvazquez: new pull request created: #12673

Details

In response to this:

/cherry-pick release/2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@austinvazquez austinvazquez added cherry-picked/2.1.x PR commits are cherry picked into the release/2.1 branch cherry-picked/2.2.x PR commits are cherry-picked into release/2.2 branch and removed cherry-pick/2.1.x Change to be cherry picked to release/2.1 branch cherry-pick/2.2.x Change to be cherry picked to release/2.2 branch labels Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/nri Node Resource Interface (NRI) cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch cherry-picked/2.1.x PR commits are cherry picked into the release/2.1 branch cherry-picked/2.2.x PR commits are cherry-picked into release/2.2 branch size/XS

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

9 participants