Fix image defaults on Darwin to usable configuration #12533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the Linux default rather than the block size from the local macOS system. The local macOS block size is not relevant as the erofs file will not be mounted directly on macOS. Signed-off-by: Derek McGowan <derek@mcg.dev>
f1dc303 to
8ce044f
Compare
hsiangkao
approved these changes
Nov 18, 2025
Non-Linux hosts are not expected to be able to directly mount erofs snapshotters on the host system. Non-Linux hosts should use block mode by default with a reasonably set default block size. Signed-off-by: Derek McGowan <derek@mcg.dev>
Use the erofs differ by default on darwin. This could be default for all Unix platforms but limit the default changes to fix broken cases for backports. Signed-off-by: Derek McGowan <derek@mcg.dev>
Fix the default unpack configuration on darwin to a usable configuration. Signed-off-by: Derek McGowan <derek@mcg.dev>
Match the defaults set by the transfer service which will configure linux by default on darwin hosts. Signed-off-by: Derek McGowan <derek@mcg.dev>
8ce044f to
c2b22d6
Compare
estesp
approved these changes
Nov 18, 2025
fuweid
approved these changes
Nov 18, 2025
Member
Author
|
/cherry-pick release/2.2 |
|
@dmcgowan: new pull request created: #12544 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the defaults for the pull process to match the snapshotter/differ defaults on darwin.
Some of these defaults, such as trying erofs for differ service, could be safely applied to Linux as well. This change is scoped to fixing broken defaults rather than changing existing or otherwise working defaults. We should consider making those default changes for the next release though.