remotes: fix possible panic from WithMediaTypeKeyPrefix #12508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the same instance of a map is used in context and mutated directly, this leads to a situation where: - Calling WithMediaTypeKeyPrefix from parallel goroutines where the context was based on the same base context can trigger a panic. - A subcontext calling WithMediaTypeKeyPrefix changes the value for another context when they both originate from the same base context. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
cpuguy83
approved these changes
Nov 12, 2025
dmcgowan
approved these changes
Nov 14, 2025
Member
|
/cherry-pick release/2.2 |
|
@dmcgowan: new pull request created: #12516 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the same instance of a map is used in context and mutated directly, this leads toa situation where:
@dmcgowan @cpuguy83 @AkihiroSuda