[release/2.1] update release builds to 1.24.7 and add 1.25.1 to CI #12258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
reviewed
Aug 31, 2025
.github/workflows/ci.yml
Outdated
| matrix: | ||
| os: [ubuntu-22.04, ubuntu-24.04, ubuntu-24.04-arm, macos-13, windows-2022] | ||
| go-version: ["1.23.12", "1.24.6"] | ||
| go-version: ["1.24.6", "1.25.0"] |
Member
There was a problem hiding this comment.
shouldn't CI continue to test the minimum version?
Member
Author
There was a problem hiding this comment.
We are changing the minimum version to 1.24.x since 1.23 is now EOL. Should we update the go.mod too?
Member
There was a problem hiding this comment.
Why are we changing minimum versions in release branches?
Member
Author
There was a problem hiding this comment.
Since we dont want to keep an EOL go version as the minimal one.
Also, 2.1 has almost another year of support, if we decide not to change the minimum version in release branches, 1.23 will have to be maintained in CI for a long time.
AkihiroSuda
approved these changes
Sep 11, 2025
AkihiroSuda
reviewed
Sep 11, 2025
4399d70 to
1e07c56
Compare
cpuguy83
reviewed
Sep 11, 2025
Member
cpuguy83
left a comment
There was a problem hiding this comment.
Looks like the commit (and pr title) are inaccurate since this is bumping to 1.24.
1e07c56 to
669b33f
Compare
- upgrade release builds from go1.23.12 to go1.24.7 - add 1.25.1 to CI NOTE: 1.23.12 is maintained in the CI, since go1.23 is the minimum version supported by containerd Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
669b33f to
c54585b
Compare
laurazard
approved these changes
Sep 11, 2025
dmcgowan
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.