Update pkg/oci to use fs.FS interface and os.OpenRoot #12245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks derek, I'm still working on some erofs-utils improvements (now stablizing C apis, and S3, OCI registry, virtual block device support in erofs-utils especially for quick new kernel feature showcase), hopefully I could switch to go-erofs development soon too. |
fuweid
reviewed
Aug 28, 2025
aebebe7 to
934aa05
Compare
Switch to use fs.FS interface over directly requiring path string. Use os.OpenRoot over continuity RootPath. Signed-off-by: Derek McGowan <derek@mcg.dev>
934aa05 to
cc2a52c
Compare
fuweid
approved these changes
Aug 29, 2025
mxpv
approved these changes
Aug 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to use fs.FS interface over directly requiring path string. This interface allows the filesystem operations to be further abstracted, then we can use any library which can return an FS from mounts without requiring an active mount. This is useful for supporting erofs on hosts which cannot directly mount it.
Using os.OpenRoot over continuity's RootPath is the preferred solution going forward as it is part of the standard library and able to leverage the openat syscall. Switching with this package first is the safest since it does not resolve user provided paths against the root.