-
Notifications
You must be signed in to change notification settings - Fork 3.8k
add SystemdCgroup to default runtime options #12244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SystemdCgroup to default runtime options #12244
Conversation
even though the SystemdCgroup key was used/respected by runtime options, it was not present as part of the default generated config. Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
b12e685 to
56cde7d
Compare
rata
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
/cherrypick release/2.1 |
|
/cherrypick release/2.0 |
|
@akhilerm: new pull request created: #12253 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@akhilerm: new pull request created: #12254 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release/2.1 |
|
@akhilerm: new pull request could not be created: failed to create pull request against containerd/containerd#release/2.0 from head k8s-infra-cherrypick-robot:cherry-pick-12244-to-release/2.0: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for k8s-infra-cherrypick-robot:cherry-pick-12244-to-release/2.0."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release/2.1 |
|
@akhilerm: new pull request could not be created: failed to create pull request against containerd/containerd#release/2.1 from head k8s-infra-cherrypick-robot:cherry-pick-12244-to-release/2.1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for k8s-infra-cherrypick-robot:cherry-pick-12244-to-release/2.1."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
even though the SystemdCgroup key was used/respected by runtime options, it was not present as part of the default generated config.
Fixes: #12101