Skip to content

Conversation

@akhilerm
Copy link
Member

even though the SystemdCgroup key was used/respected by runtime options, it was not present as part of the default generated config.

Fixes: #12101

@github-project-automation github-project-automation bot moved this to Needs Triage in Pull Request Review Aug 28, 2025
@dosubot dosubot bot added the area/cri Container Runtime Interface (CRI) label Aug 28, 2025
@akhilerm akhilerm added cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch cherry-pick/2.1.x Change to be cherry picked to release/2.1 branch labels Aug 28, 2025
even though the SystemdCgroup key was used/respected by runtime options, it was
not present as part of the default generated config.

Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
@akhilerm akhilerm force-pushed the add-systemdcgroup-runtimeconfig branch from b12e685 to 56cde7d Compare August 29, 2025 05:33
Copy link
Contributor

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@github-project-automation github-project-automation bot moved this from Needs Triage to Review In Progress in Pull Request Review Aug 29, 2025
@mxpv mxpv added this pull request to the merge queue Aug 30, 2025
Merged via the queue into containerd:main with commit 956f0bc Aug 30, 2025
95 of 97 checks passed
@github-project-automation github-project-automation bot moved this from Review In Progress to Done in Pull Request Review Aug 30, 2025
@akhilerm akhilerm deleted the add-systemdcgroup-runtimeconfig branch August 30, 2025 04:38
@akhilerm
Copy link
Member Author

/cherrypick release/2.1

@akhilerm
Copy link
Member Author

/cherrypick release/2.0

@k8s-infra-cherrypick-robot

@akhilerm: new pull request created: #12253

Details

In response to this:

/cherrypick release/2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@akhilerm: new pull request created: #12254

Details

In response to this:

/cherrypick release/2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@akhilerm akhilerm added cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch cherry-picked/2.1.x PR commits are cherry picked into the release/2.1 branch and removed cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch cherry-pick/2.1.x Change to be cherry picked to release/2.1 branch labels Aug 30, 2025
@akhilerm
Copy link
Member Author

/cherrypick release/2.1
/cherrypick release/2.0

@k8s-infra-cherrypick-robot

@akhilerm: new pull request could not be created: failed to create pull request against containerd/containerd#release/2.0 from head k8s-infra-cherrypick-robot:cherry-pick-12244-to-release/2.0: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for k8s-infra-cherrypick-robot:cherry-pick-12244-to-release/2.0."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

Details

In response to this:

/cherrypick release/2.1
/cherrypick release/2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@akhilerm
Copy link
Member Author

/cherrypick release/2.1

@k8s-infra-cherrypick-robot

@akhilerm: new pull request could not be created: failed to create pull request against containerd/containerd#release/2.1 from head k8s-infra-cherrypick-robot:cherry-pick-12244-to-release/2.1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for k8s-infra-cherrypick-robot:cherry-pick-12244-to-release/2.1."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

Details

In response to this:

/cherrypick release/2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cri Container Runtime Interface (CRI) cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch cherry-picked/2.1.x PR commits are cherry picked into the release/2.1 branch size/XS

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

SystemdCgroup is not present in default config even though it is a supported key for runtimes.runc.options

7 participants