Skip to content

fix: create bootstrap.json with 0644 permission #12177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mxpv merged 1 commit into from
Aug 7, 2025
Merged

fix: create bootstrap.json with 0644 permission #12177

mxpv merged 1 commit into from
Aug 7, 2025

Conversation

@swagatbora90
Copy link
Contributor

@swagatbora90 swagatbora90 commented Aug 6, 2025

Fixes: #12176

Also needs to be backported to release/2.0 and release/2.1

@swagatbora90
fix: create bootstrap.json with 0644 permission
7340a7a 
Signed-off-by: Swagat Bora <sbora@amazon.com>
@github-project-automation github-project-automation bot moved this to Needs Triage in Pull Request Review Aug 6, 2025
@k8s-ci-robot
Copy link

k8s-ci-robot commented Aug 6, 2025

Hi @swagatbora90. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@austinvazquez
Copy link
Member

austinvazquez commented Aug 7, 2025

/ok-to-test

@austinvazquez austinvazquez added cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch cherry-pick/2.1.x Change to be cherry picked to release/2.1 branch labels Aug 7, 2025
austinvazquez
austinvazquez approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@github-project-automation github-project-automation bot moved this from Needs Triage to Review In Progress in Pull Request Review Aug 7, 2025
@mxpv mxpv added this pull request to the merge queue Aug 7, 2025
Merged via the queue into containerd:main with commit 3149356 Aug 7, 2025
50 checks passed
@github-project-automation github-project-automation bot moved this from Review In Progress to Done in Pull Request Review Aug 7, 2025
@austinvazquez
Copy link
Member

austinvazquez commented Aug 8, 2025

/cherry-pick release/2.1

@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Aug 8, 2025

@austinvazquez: new pull request created: #12183

Details

In response to this:

/cherry-pick release/2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 8, 2025
Merged
@austinvazquez
Copy link
Member

austinvazquez commented Aug 8, 2025

/cherry-pick release/2.0

@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Aug 8, 2025

@austinvazquez: new pull request created: #12184

Details

In response to this:

/cherry-pick release/2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 8, 2025
Merged
@austinvazquez austinvazquez added cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch and removed cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch cherry-pick/2.1.x Change to be cherry picked to release/2.1 branch labels Aug 8, 2025
@austinvazquez austinvazquez added the cherry-picked/2.1.x PR commits are cherry picked into the release/2.1 branch label Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxpv mxpv mxpv approved these changes

@henry118 henry118 henry118 approved these changes

@austinvazquez austinvazquez austinvazquez approved these changes

Assignees

No one assigned

Labels

area/runtime Runtime cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch cherry-picked/2.1.x PR commits are cherry picked into the release/2.1 branch kind/bug ok-to-test size/XS

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

File permission inconsistency: bootstrap.json created with 0o666

6 participants

@swagatbora90 @k8s-ci-robot @austinvazquez @k8s-infra-cherrypick-robot @mxpv @henry118