Add snapshotter and differ for block CIMs #12050
Conversation
|
Hi @ambarve. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
95360c6 to
86cc301
Compare
e96a212 to
b16f046
Compare
b16f046 to
d14117f
Compare
d14117f to
e0f0761
Compare
| return false, err | ||
| } | ||
| return true, nil | ||
| } |
There was a problem hiding this comment.
Can we add a Cleanup() function like the other linux snapshotters have to take care of deleting any orphaned directories? I think we had decided on adding one for windows snapshotter for long term too.
There was a problem hiding this comment.
I looked at the changes required for this and I think this will affect the existing Windows & cimfs snapshotters too. Plus, we may also want to implement it for the LCOW snapshotter. I think that should be a separate PR. What do you think?
|
LGTM |
cpuguy83
left a comment
There was a problem hiding this comment.
I don't see anything glaringly wrong here.
3d437da to
05c04dc
Compare
05c04dc to
adec7d7
Compare
adec7d7 to
beede8d
Compare
Add new snapshotter & differ plugins that can leverage the block CIM layer writers to store pulled/imported images in the block CIM format. Signed-off-by: Amit Barve <ambarve@microsoft.com>
beede8d to
0096252
Compare
|
/retest |
This commit adds the snapshotter and differ plugins that can be used to pull/import container images in the block CIM format. (More about block CIMs here.)