Skip to content

Conversation

@chrishenzie
Copy link
Contributor

Introduces a new GitHub Actions workflow to run Kubernetes node e2e tests against containerd pull requests. This is the first step in migrating containerd's CI off of the community-owned prow.k8s.io infrastructure.

This new workflow is modeled after the existing presubmit job.

Initially this workflow will not be required to pass on PRs. We can make it required later once it's proven to be stable.

Part of #11486 (but doesn't fully fix it yet).

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@chrishenzie
Copy link
Contributor Author

/test all

@chrishenzie chrishenzie force-pushed the github-actions branch 5 times, most recently from 5c7e014 to 6697cc8 Compare June 26, 2025 17:58
@chrishenzie chrishenzie force-pushed the github-actions branch 10 times, most recently from ea480c3 to ee61c53 Compare June 27, 2025 05:24
@chrishenzie chrishenzie marked this pull request as ready for review June 27, 2025 05:25
@chrishenzie
Copy link
Contributor Author

/cc @BenTheElder
/cc @dims
/cc @samuelkarp

@k8s-ci-robot k8s-ci-robot requested review from dims and samuelkarp June 27, 2025 05:26
@k8s-ci-robot
Copy link

@chrishenzie: GitHub didn't allow me to request PR reviews from the following users: BenTheElder.

Note that only containerd members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @BenTheElder
/cc @dims
/cc @samuelkarp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrishenzie
Copy link
Contributor Author

chrishenzie commented Jun 27, 2025

NOTE: You can view the test output by checking the E2E / Kubernetes Node action below.


There may be some more configuration bits we need to borrow from the existing configure-helper.sh script.

The main difference between this workflow and the existing Prow job is that we're skipping [Feature:ResourceMetrics] tests, specifically the ResourceMetricsAPI test. It looked like it was related to this PodAndContainerStatsFromCRI feature gate.

However the test failed whether the gate was enabled or disabled. Here's an example failure if you'd like to take a look.

@dosubot dosubot bot added the github_actions Pull requests that update GitHub Actions code label Jun 27, 2025
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; looks like a solid starting point for migrating off prow

@github-project-automation github-project-automation bot moved this from Needs Triage to Review In Progress in Pull Request Review Jun 30, 2025
@estesp estesp added this pull request to the merge queue Jul 1, 2025
@chrishenzie chrishenzie removed this pull request from the merge queue due to a manual request Jul 1, 2025
@chrishenzie
Copy link
Contributor Author

/hold
Addressing the runc feedback

Introduces a workflow to run Kubernetes node e2e tests against
containerd pull requests. This is the first step in migrating
containerd's CI off of the community-owned prow.k8s.io infrastructure.

This new workflow is modeled after the existing presubmit job:
https://github.com/kubernetes/test-infra/blob/master/config/jobs/containerd/containerd/containerd-presubmit-jobs.yaml

Initially this workflow will not be required to pass on PRs. We can make
it required later once it's proven to be stable.

Signed-off-by: Chris Henzie <chrishenzie@google.com>
@estesp estesp added this pull request to the merge queue Jul 2, 2025
Merged via the queue into containerd:main with commit a0281df Jul 2, 2025
88 of 91 checks passed
@github-project-automation github-project-automation bot moved this from Review In Progress to Done in Pull Request Review Jul 2, 2025
@chrishenzie chrishenzie deleted the github-actions branch July 2, 2025 16:00
@mikebrow
Copy link
Member

@chrishenzie thx for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code size/L

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants