fix(cri): Correct Commit Memory Aggregation for Windows Containers #12015
Conversation
|
Hi @rzlink. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@kiashok - FYI |
|
thanks for the contribution; you need to amend your commit to add a |
Summary Fixes Windows container memory stats by correctly aggregating CommitMemoryBytes and handling missing stats gracefully. Key Changes Fixed aggregation of CommitMemoryBytes in appendMemoryPodStats Mapped MemoryUsageCommitBytes to container UsageBytes Handled nil stats without breaking pod-level reporting Added tests for missing memory stats and updated assertions Bug Pod-level memory stats were incomplete due to missing CommitMemoryBytes aggregation. This fix ensures accurate reporting across containers. Testing New test for missing stats All existing tests pass Improved test clarity and coverage Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
|
@rzlink: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@rzlink: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@rzlink: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/retest |
|
@estesp , It looks like the PR was removed from the merge queue due to a flaky test failure. Could you please requeue it? |
Summary
Fixes Windows container memory stats by correctly aggregating CommitMemoryBytes and handling missing stats gracefully.
Key Changes
Fixed aggregation of
CommitMemoryBytesinappendMemoryPodStatsMapped
MemoryUsageCommitBytesto containerUsageBytesHandled nil stats without breaking pod-level reporting
Added tests for missing memory stats and updated assertions
Bug
Pod-level memory stats were incomplete due to missing CommitMemoryBytes aggregation. This fix ensures accurate reporting across containers.
Testing
New test for missing stats
All existing tests pass
Improved test clarity and coverage