[release/2.0] Enable CIs to run on WS2022 and WS2025#11970
Conversation
|
Looks like you also need hcsshim 0.13 or above for this to work 🤔 The commit that added the current version strings is only in hcsshim 0.13 and above. |
d738ce0 to
689ade8
Compare
|
Oof that dependency update exploded the delta. Mostly vendored code though, but it looks like there are some build failures which I don't see on Linux. So might need to go through some pull requests and find the missing piece. |
689ade8 to
f23e38a
Compare
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com> (cherry picked from commit 2f1948a) Signed-off-by: Austin Vazquez <austin.vazquez.dev@gmail.com>
f23e38a to
9724cd5
Compare
|
Okay, I might have something that works. I backtracked a bit and dropped pulling in Microsoft/hcsshim@v0.13.0 build dep update. So I found the v0.12.9->v0.13.0-rc3 jump happened in 306c47f. I looked at doing it myself for release/2.0 branch but found it would bring some breaking changes to pkg/archive cc: @kiashok wdyt, am I way off base here? |
| // Windows Server 2025 build 26100 | ||
| // The Windows Server 2025 constant was added in Microsoft/hcsshim@v0.13.0. | ||
| // Copied here to avoid updating the hcsshim dependency which requires breaking changes in the archive package. | ||
| V25H1Server = 26100 |
There was a problem hiding this comment.
this makes sense to me.. we can see what @kiashok says
|
@kiashok, curious if you could take a look at this one to unblock a 2.0 release. Slight changes to the fixes you made for mainline and 2.1 branches. |
estesp
left a comment
There was a problem hiding this comment.
I think to move forward, adding the constant defined in the tests is a reasonable workaround compared to an hcsshim update; let's merge this
This change backports the Windows runner image updates for Windows 2019 deprecation to release/2.0.
(cherry picked from commit 2f1948a)
Note: not a clean cherry-pick; edited to include a copy of Windows 2025 constant copied from Microsoft/hcsshim@v0.13.0