-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Update GHA runners to use latest image for most jobs #11933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skipping CI for Draft Pull Request. |
933daa2 to
540876d
Compare
|
I guess |
|
Looks like this worked.. was this just a test or are you going to move out of Draft for review? I'm asking because I think @kiashok is going to get a PR ready for all the Windows testing/image updates for actions |
austinvazquez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giving my thumbs up ahead of time. The jobs listed here should be fine.
|
We can take this, it doesn't make any changes to the tests and we might want to get it backported before the next brownout. While we are waiting for the tests to move off of 2019 this at least allows the rest of CI to complete during the brownouts |
akhilerm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update the api-release workflows also to use the ubuntu-latest along with this change.
Ref: https://github.com/containerd/containerd/blob/main/.github/workflows/api-release.yml#L18
|
Needs rebase. |
For jobs which do not require a version matrix, such as some testing runs, use the latest runner image. Pinning the images unnecessarily causes more work later on when deciding when to upgrade and may cause more issues when older images brownout. Signed-off-by: Derek McGowan <derek@mcg.dev>
540876d to
d553c40
Compare
|
Updated, even if |
For jobs which do not require a version matrix, such as some testing runs, use the latest runner image. Pinning the images unnecessarily causes more work later on when deciding when to upgrade and may cause more issues when older images brownout. It is preferable to catch issues when the latest is updated for jobs that should not be version dependent.