Skip to content

Conversation

@dmcgowan
Copy link
Member

@dmcgowan dmcgowan commented Jun 3, 2025

For jobs which do not require a version matrix, such as some testing runs, use the latest runner image. Pinning the images unnecessarily causes more work later on when deciding when to upgrade and may cause more issues when older images brownout. It is preferable to catch issues when the latest is updated for jobs that should not be version dependent.

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dmcgowan dmcgowan force-pushed the gha-use-latest-images branch from 933daa2 to 540876d Compare June 3, 2025 20:54
@estesp
Copy link
Member

estesp commented Jun 3, 2025

I guess windows-latest is not pointing to windows-2025 yet? Noticed this in the logs for OS:

Operating System
  Microsoft Windows Server 2022
  10.0.20[3](https://github.com/containerd/containerd/actions/runs/15427653032/job/43418472164?pr=11933#step:1:3)48
  Datacenter

@estesp
Copy link
Member

estesp commented Jun 4, 2025

Looks like this worked.. was this just a test or are you going to move out of Draft for review? I'm asking because I think @kiashok is going to get a PR ready for all the Windows testing/image updates for actions

Copy link
Member

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving my thumbs up ahead of time. The jobs listed here should be fine.

@dmcgowan dmcgowan marked this pull request as ready for review June 5, 2025 00:01
@dosubot dosubot bot added the github_actions Pull requests that update GitHub Actions code label Jun 5, 2025
@dmcgowan
Copy link
Member Author

dmcgowan commented Jun 5, 2025

We can take this, it doesn't make any changes to the tests and we might want to get it backported before the next brownout. While we are waiting for the tests to move off of 2019 this at least allows the rest of CI to complete during the brownouts

Copy link
Member

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the api-release workflows also to use the ubuntu-latest along with this change.
Ref: https://github.com/containerd/containerd/blob/main/.github/workflows/api-release.yml#L18

@github-project-automation github-project-automation bot moved this from Needs Triage to Review In Progress in Pull Request Review Jun 5, 2025
@cpuguy83
Copy link
Member

Needs rebase.

For jobs which do not require a version matrix, such as some testing
runs, use the latest runner image. Pinning the images unnecessarily
causes more work later on when deciding when to upgrade and may cause
more issues when older images brownout.

Signed-off-by: Derek McGowan <derek@mcg.dev>
@dmcgowan
Copy link
Member Author

Updated, even if windows-latest is still on 2022, I still think its worth using the latest tag for linters. Whenever it gets updated we know 2025 runs the linters fine anyway.

@estesp estesp added this pull request to the merge queue Jun 27, 2025
Merged via the queue into containerd:main with commit 5bf40cb Jun 27, 2025
52 checks passed
@github-project-automation github-project-automation bot moved this from Review In Progress to Done in Pull Request Review Jun 27, 2025
@austinvazquez austinvazquez added cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch cherry-picked/2.1.x PR commits are cherry picked into the release/2.1 branch labels Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch cherry-picked/2.1.x PR commits are cherry picked into the release/2.1 branch github_actions Pull requests that update GitHub Actions code size/S

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants