Skip to content

[release/1.6] test: added runc v1 support in vagrant#11913

Merged
dmcgowan merged 1 commit intocontainerd:release/1.6from
Madraceee:vagrant_v1_tests_1.6
Jun 3, 2025
Merged

[release/1.6] test: added runc v1 support in vagrant#11913
dmcgowan merged 1 commit intocontainerd:release/1.6from
Madraceee:vagrant_v1_tests_1.6

Conversation

@Madraceee
Copy link

@Madraceee Madraceee commented May 29, 2025

fix: #11830

Added jobs to ci.yml to test runc v1 using vagrant
ping @akhilerm

@github-project-automation github-project-automation bot moved this to Needs Triage in Pull Request Review May 29, 2025
@k8s-ci-robot
Copy link

k8s-ci-robot commented May 29, 2025

Hi @Madraceee. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dosubot dosubot bot added github_actions Pull requests that update GitHub Actions code kind/test labels May 29, 2025
@austinvazquez
Copy link
Member

austinvazquez commented May 29, 2025

/ok-to-test

@Madraceee
Copy link
Author

Madraceee commented May 29, 2025 •
edited
Loading

Changes are good?

austinvazquez
austinvazquez approved these changes May 29, 2025
View reviewed changes
Copy link
Member

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, changes LGTM

akhilerm
akhilerm requested changes May 30, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from Needs Triage to Needs Update in Pull Request Review May 30, 2025
@Madraceee
test: added runc v1 support in vagrant
9e49725 
Signed-off-by: Nitheesh Raaja R <raajanitheesh@gmail.com>
@Madraceee Madraceee force-pushed the vagrant_v1_tests_1.6 branch from e659b10 to 9e49725 Compare May 30, 2025 05:05
@Madraceee
Copy link
Author

Madraceee commented May 30, 2025

I have made the changes. I checked the logs, not sure whether thats the expected outcome. Let me know if any changes are required.

@akhilerm akhilerm mentioned this pull request May 30, 2025
Closed
2 tasks
@github-project-automation github-project-automation bot moved this from Needs Update to Review In Progress in Pull Request Review May 30, 2025
@dmcgowan dmcgowan merged commit b776711 into containerd:release/1.6 Jun 3, 2025
49 checks passed
@github-project-automation github-project-automation bot moved this from Review In Progress to Done in Pull Request Review Jun 3, 2025
@austinvazquez austinvazquez mentioned this pull request Jul 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@akhilerm akhilerm akhilerm approved these changes

@austinvazquez austinvazquez austinvazquez approved these changes

Assignees

No one assigned

Labels

github_actions Pull requests that update GitHub Actions code kind/test ok-to-test size/S

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Madraceee @k8s-ci-robot @austinvazquez @dmcgowan @akhilerm