Skip to content

Update k8s.io modules to v0.33.0 #11749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chrishenzie wants to merge 1 commit into from
Closed

Update k8s.io modules to v0.33.0 #11749

chrishenzie wants to merge 1 commit into from

Conversation

@chrishenzie
Copy link
Contributor

@chrishenzie chrishenzie commented Apr 23, 2025

Most importantly, pulling in CRI API changes needed for PodSandboxUpdate.

@github-project-automation github-project-automation bot moved this to Needs Triage in Pull Request Review Apr 23, 2025
@k8s-ci-robot
Copy link

k8s-ci-robot commented Apr 23, 2025

Hi @chrishenzie. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dosubot dosubot bot added area/cri Container Runtime Interface (CRI) dependencies Pull requests that update a dependency file labels Apr 23, 2025
chrishenzie
chrishenzie commented Apr 23, 2025
View reviewed changes
go.mod
module github.com/containerd/containerd/v2

go 1.23.0
go 1.24.0
Copy link
Contributor Author

@chrishenzie chrishenzie Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about this, do we want to stay on 1.23?

Copy link
Member

@samuelkarp samuelkarp Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need to stay on 1.23. See kubernetes/kubernetes#130799.

@chrishenzie chrishenzie changed the title Update k8s.io imports to v0.33.0 Update k8s.io modules to v0.33.0 Apr 23, 2025
samuelkarp
samuelkarp requested changes Apr 23, 2025
View reviewed changes
Copy link
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not merge this at this time, as it forces containerd to use Go 1.24 which has known issues outlined in kubernetes/kubernetes#130799 (comment).

@github-project-automation github-project-automation bot moved this from Needs Triage to Needs Update in Pull Request Review Apr 23, 2025
@chrishenzie
Copy link
Contributor Author

chrishenzie commented Apr 23, 2025

Ack, thanks for the context

@github-project-automation github-project-automation bot moved this from Needs Update to Done in Pull Request Review Apr 23, 2025
@chrishenzie chrishenzie deleted the k8s-1-33 branch April 23, 2025 22:38
This was referenced Apr 23, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelkarp samuelkarp samuelkarp requested changes

Assignees

No one assigned

Labels

area/cri Container Runtime Interface (CRI) dependencies Pull requests that update a dependency file needs-ok-to-test size/XXL

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chrishenzie @k8s-ci-robot @samuelkarp