Conversation
chrishenzie
left a comment
There was a problem hiding this comment.
For context, why is reverting to 1.23 necessary for 2.1?
|
We should probably update to 1.23.8 as well |
We always ship release binaries on the older stable version of go and test with both the supported versions. |
go1.24 also has a couple of regressions that can result in segfaults(some fixes will be in go1.24.3) |
cf8ea1b to
27648e9
Compare
Done. Updated both 1.23.8 and 1.24.2 in a separate commit |
contrib/Dockerfile.test
Outdated
| # ------------------------------------------------------------------------------ | ||
|
|
||
| ARG GOLANG_VERSION=1.24.1 | ||
| ARG GOLANG_VERSION=1.24.2 |
There was a problem hiding this comment.
Can you make this one 1.23.8? Historically, this was the best location for our pipelines to get the version to use to build, and I think our script still greps this file for GOLANG_VERSION
There was a problem hiding this comment.
Curious, Isnt the best place to get the version here https://github.com/containerd/containerd/blob/main/.github/actions/install-go/action.yml#L6.
There was a problem hiding this comment.
Have updated here also.
.github/workflows/api-release.yml
Outdated
|
|
||
| env: | ||
| GO_VERSION: "1.24.1" | ||
| GO_VERSION: "1.24.2" |
There was a problem hiding this comment.
This probably also should be 1.23.8 (?), although I guess API doesn't produce binaries
There was a problem hiding this comment.
although I guess API doesn't produce binaries
Yes . Thats why I didnt change that. But can update to 1.23.8
- go1.23.8 (released 2025-04-01) includes security fixes to the net/http package, as well as bug fixes to the runtime and the go command. Ref: https://github.com/golang/go/issues?q=milestone%3AGo1.23.8+label%3ACherryPickApproved - go1.24.2 (released 2025-04-01) includes security fixes to the net/http package, as well as bug fixes to the compiler, the runtime, the go command, and the crypto/tls, go/types, net/http, and testing packages. Ref: https://github.com/golang/go/issues?q=milestone%3AGo1.24.2+label%3ACherryPickApproved Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
use go1.23.8 as the default go version for running in CI and making release binaries. NOTE: This is done so that when release/2.1 branch cut happens the 2.1 release uses 1.23.x for building release binaries rather than 1.24.x. Once the 2.1 release is out, this will be reverted and go1.24.x will be made the default in the main branch Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
27648e9 to
6f93c65
Compare
update go 1.24.2, 1.23.8 for build and testing
use go1.23.8 as the default go version for running in CI and making release binaries.
NOTE: This is done so that when release/2.1 branch cut happens, the 2.1 release uses 1.23.x for building release binaries rather than 1.24.x. Once the 2.1 release is out, this patch will be reverted and go1.24.x will be made the default in the main branch