Skip to content

Prevent panic in Docker pusher.#11670

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
ctalledo:fix-moby-46746
Apr 14, 2025
Merged

Prevent panic in Docker pusher.#11670
dmcgowan merged 1 commit intocontainerd:mainfrom
ctalledo:fix-moby-46746

Conversation

@ctalledo
Copy link
Contributor

@ctalledo ctalledo commented Apr 9, 2025

Prevent a panic in the Docker pusher pushWriter object, by checking that the pipe it writes to is non nil before attempting to use it.

The panic was found by Moby issue #46746 (moby/moby#46746). With this fix the panic no longer reproduces.

Prevent a panic in the Docker pusher pushWriter, by checking that
the pipe is non nil before attempting to use it.

The panic was found by Moby issue #46746 (moby/moby#46746).
With this fix the panic no longer reproduces.

Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
@k8s-ci-robot
Copy link

Hi @ctalledo. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-project-automation github-project-automation bot moved this from Needs Triage to Review In Progress in Pull Request Review Apr 9, 2025
@estesp estesp enabled auto-merge April 9, 2025 14:49
@estesp estesp added the cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch label Apr 9, 2025
@estesp estesp moved this from Review In Progress to Merge on Green in Pull Request Review Apr 9, 2025
@dmcgowan dmcgowan disabled auto-merge April 14, 2025 21:24
@dmcgowan dmcgowan merged commit f430ef2 into containerd:main Apr 14, 2025
54 of 56 checks passed
@github-project-automation github-project-automation bot moved this from Merge on Green to Done in Pull Request Review Apr 14, 2025
@dmcgowan
Copy link
Member

dmcgowan commented Apr 14, 2025

/cherry-pick release/2.0

@k8s-infra-cherrypick-robot

@dmcgowan: new pull request created: #11698

Details

In response to this:

/cherrypick release/2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ctalledo ctalledo deleted the fix-moby-46746 branch April 14, 2025 22:46
@austinvazquez austinvazquez added cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch and removed cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch labels May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/distribution Image Distribution cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch kind/bug needs-ok-to-test size/S

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

8 participants