Skip to content

ci: bump golangci from 6.5.2 to 7.0.0#11623

Merged
dmcgowan merged 11 commits into
containerd:mainfrom
yashsingh74:update-golangci-v2
Jul 1, 2025
Merged

ci: bump golangci from 6.5.2 to 7.0.0#11623
dmcgowan merged 11 commits into
containerd:mainfrom
yashsingh74:update-golangci-v2

Conversation

@yashsingh74

@yashsingh74 yashsingh74 commented Mar 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR updates the golangci version to v2 used in the CI pipeline from 6.5.2 to 7.0.0, addressing a failure linked to PR #11597.

Migration has been done using the config migrate tool.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Pull Request Review Mar 30, 2025
@k8s-ci-robot

k8s-ci-robot commented Mar 30, 2025

Copy link
Copy Markdown

Hi @yashsingh74. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dosubot dosubot Bot added the area/github_actions Pull requests that update GitHub Actions code label Mar 30, 2025
akhilerm
akhilerm reviewed Apr 1, 2025
View reviewed changes
Comment thread .golangci.yml Outdated
@yashsingh74 yashsingh74 force-pushed the update-golangci-v2 branch 3 times, most recently from 5cdab55 to 5b880a0 Compare April 3, 2025 05:55
@akhilerm

akhilerm commented Apr 3, 2025

Copy link
Copy Markdown
Member

/ok-to-test

@akhilerm akhilerm mentioned this pull request Apr 7, 2025
Closed
akhilerm
akhilerm reviewed Apr 7, 2025
View reviewed changes
Comment thread .golangci.yml
Comment thread .golangci.yml
Comment thread core/remotes/docker/schema1/converter.go Outdated
Comment thread internal/cri/server/container_create.go Outdated
github-advanced-security[bot]
github-advanced-security AI found potential problems Apr 9, 2025
View reviewed changes
Comment thread pkg/archive/tar.go Fixed
thaJeztah
thaJeztah reviewed Jun 5, 2025
View reviewed changes
Comment thread internal/cri/server/sandbox_stats_windows.go Outdated
@yashsingh74 yashsingh74 force-pushed the update-golangci-v2 branch 2 times, most recently from 2514ccc to 8ad61cc Compare June 11, 2025 14:06
yashsingh74 added 11 commits June 18, 2025 14:16
@yashsingh74
fix: QF1002: could use tagged switch on host (staticcheck)
5651617 
Signed-off-by: yashsingh74 <yashsingh1774@gmail.com>
@yashsingh74
fix: QF1004: strings.ReplaceAll instead (staticcheck)
1ff5900 
Signed-off-by: yashsingh74 <yashsingh1774@gmail.com>
@yashsingh74
fix: ST1005: error strings should not end with punctuation or newlines
b3eec6d 
Signed-off-by: yashsingh74 <yashsingh1774@gmail.com>
@yashsingh74
fix: QF1001: could apply De Morgan's law (staticcheck)
d93d18c 
Signed-off-by: yashsingh74 <yashsingh1774@gmail.com>
@yashsingh74
fix: QF1012: Use of fmt.Fprintln(...)
403f86e 
Signed-off-by: yashsingh74 <yashsingh1774@gmail.com>
@yashsingh74
fix: ST1019: removed the duplicate imports
b529973 
Signed-off-by: yashsingh74 <yashsingh1774@gmail.com>
@yashsingh74
fix: ST1001: should not use dot imports (staticcheck)
4ba81d4 
Signed-off-by: yashsingh74 <yashsingh1774@gmail.com>
@yashsingh74
fix: Used nolint to ignore the static checks
03a44a2 
Signed-off-by: yashsingh74 <yashsingh1774@gmail.com>
@yashsingh74
Disable QF1003: could use tagged switch on base (staticcheck)
19a7130 
Signed-off-by: yashsingh74 <yashsingh1774@gmail.com>
@yashsingh74
Disable ST1003: struct field Uid should be UID (staticcheck)
37147b1 
Signed-off-by: yashsingh74 <yashsingh1774@gmail.com>
@yashsingh74
ci: bump golangci from 6.5.2 to 7.0.0
ed77466 
Signed-off-by: yashsingh74 <yashsingh1774@gmail.com>
@yashsingh74

yashsingh74 commented Jun 18, 2025

Copy link
Copy Markdown
Contributor Author

/test pull-containerd-k8s-e2e-ec2

@akhilerm

akhilerm commented Jun 27, 2025

Copy link
Copy Markdown
Member

@thaJeztah Can we get this changes in ?

@akhilerm

akhilerm commented Jul 1, 2025

Copy link
Copy Markdown
Member

/retest pull-containerd-k8s-e2e-ec2

@k8s-ci-robot

k8s-ci-robot commented Jul 1, 2025

Copy link
Copy Markdown

@akhilerm: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test pull-containerd-build

/test pull-containerd-node-e2e

The following commands are available to trigger optional jobs:

/test pull-containerd-k8s-e2e-ec2

Use /test all to run all jobs.

Details

In response to this:

/retest pull-containerd-k8s-e2e-ec2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@akhilerm

akhilerm commented Jul 1, 2025

Copy link
Copy Markdown
Member

/test pull-containerd-k8s-e2e-ec2

@dmcgowan dmcgowan dismissed thaJeztah’s stale review July 1, 2025 18:06

Feedback addressed

@dmcgowan dmcgowan added this pull request to the merge queue Jul 1, 2025
Merged via the queue into containerd:main with commit 4d89721 Jul 1, 2025
124 of 129 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Update to Done in Pull Request Review Jul 1, 2025
@mmorel-35 mmorel-35 mentioned this pull request Jul 6, 2025
Open
@thaJeztah thaJeztah mentioned this pull request Mar 11, 2026
Merged
This was referenced Apr 9, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah left review comments

@dmcgowan dmcgowan dmcgowan approved these changes

@akhilerm akhilerm akhilerm approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@djdongjin djdongjin djdongjin approved these changes

@laurazard laurazard laurazard approved these changes

+3 more reviewers

@tariq1890 tariq1890 tariq1890 left review comments

@kolyshkin kolyshkin kolyshkin left review comments

@mmorel-35 mmorel-35 mmorel-35 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/github_actions Pull requests that update GitHub Actions code ok-to-test size/L

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.