[CRI] store extension when create sandbox in metadata store#11612
[CRI] store extension when create sandbox in metadata store#11612mxpv merged 1 commit intocontainerd:mainfrom
Conversation
|
Hi @yylt. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Signed-off-by: yang yang <yang8518296@163.com>
|
@yylt: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Should this be cherry picked to 2.0? |
yes.. |
|
/cherry-pick release/2.0 |
|
@yylt: only containerd org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release/2.0 |
|
@fuweid: new pull request created: #11808 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fix #10848
When the netns prepara fails, it will result in missing extensions in metadata store. So store extension when create the sandbox in the store
Additionally, some of the logs were modified, and the error messages and descriptions returned were somewhat inconsistent
sandboxInfo.AddExtension(...)is to copy metadata to the extension.c.client.SandboxStore().Update(..)is to updates metadata to the store./cc @mikebrow