Skip to content

*: CRIImageService should delete image synchronously#11581

Merged
samuelkarp merged 1 commit intocontainerd:mainfrom
fuweid:fix-image-deletion-sync
Mar 24, 2025
Merged

*: CRIImageService should delete image synchronously#11581
samuelkarp merged 1 commit intocontainerd:mainfrom
fuweid:fix-image-deletion-sync

Conversation

@fuweid
Copy link
Member

@fuweid fuweid commented Mar 22, 2025

Use memory service instead of metadata store.

REF: kubernetes/kubernetes#130663 (comment)

@github-project-automation github-project-automation bot moved this to Needs Triage in Pull Request Review Mar 22, 2025
@fuweid fuweid requested a review from dmcgowan March 22, 2025 01:39
@dosubot dosubot bot added the area/cri Container Runtime Interface (CRI) label Mar 22, 2025
@fuweid fuweid requested a review from mikebrow March 22, 2025 01:39
@fuweid fuweid added the cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch label Mar 22, 2025
Use memory service instead of metadata store.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
@fuweid fuweid force-pushed the fix-image-deletion-sync branch from 320a36c to e7b4165 Compare March 22, 2025 02:31
@fuweid
Copy link
Member Author

fuweid commented Mar 22, 2025

/retest

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from Needs Triage to Review In Progress in Pull Request Review Mar 24, 2025
@samuelkarp samuelkarp added this pull request to the merge queue Mar 24, 2025
Merged via the queue into containerd:main with commit 7bce8df Mar 24, 2025
59 checks passed
@github-project-automation github-project-automation bot moved this from Review In Progress to Done in Pull Request Review Mar 24, 2025
@fuweid fuweid deleted the fix-image-deletion-sync branch March 25, 2025 02:34
@fuweid
Copy link
Member Author

fuweid commented Mar 25, 2025

/cherry-pick release-2.0

@k8s-infra-cherrypick-robot

@fuweid: cannot checkout release-2.0: error checking out "release-2.0": exit status 1 error: pathspec 'release-2.0' did not match any file(s) known to git

Details

In response to this:

/cherry-pick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fuweid
Copy link
Member Author

fuweid commented Mar 25, 2025

/cherry-pick release/2.0

@k8s-infra-cherrypick-robot

@fuweid: new pull request created: #11599

Details

In response to this:

/cherry-pick release/2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cri Container Runtime Interface (CRI) cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch size/XS

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants