Skip to content

fix: check option['BinaryName'] for runtime absolute path#11557

Closed
pacoxu wants to merge 1 commit intocontainerd:mainfrom
pacoxu:fix-usns
Closed

fix: check option['BinaryName'] for runtime absolute path#11557
pacoxu wants to merge 1 commit intocontainerd:mainfrom
pacoxu:fix-usns

Conversation

@pacoxu
Copy link
Contributor

@pacoxu pacoxu commented Mar 18, 2025

kubernetes/test-infra#34510 (comment)

I0316 15:41:39.203539 26072 util.go:259] Event(v1.ObjectReference{Kind:"Pod", Namespace:"localstorage-quota-monitoring-test-8965", Name:"emptydir-concealed-disk-over-sizelimit-quotas-false-pod", UID:"bcafa216-1bf4-4ee7-8d1d-af225b9e2872", APIVersion:"v1", ResourceVersion:"3505", FieldPath:"spec.containers{emptydir-concealed-disk-over-sizelimit-quotas-false-container}"}): type: 'Warning' reason: 'Failed' Error: failed to create containerd task: failed to create shim task: OCI runtime create failed: unable to retrieve OCI runtime error (open /run/containerd/io.containerd.runtime.v2.task/k8s.io/emptydir-concealed-disk-over-sizelimit-quotas-false-container/log.json: no such file or directory): exec: "runc": executable file not found in $PATH

When running pod with usernamespace enabled, there is a failure of runc not found like above.

https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/ci-cgroupv2-containerd-node-arm64-e2e-serial-ec2/1901281724340375552

This is a fix try: I am not sure if this is a proper way to check options[binaryname].

@fuweid

@github-project-automation github-project-automation bot moved this to Needs Triage in Pull Request Review Mar 18, 2025
@k8s-ci-robot
Copy link

k8s-ci-robot commented Mar 18, 2025

Hi @pacoxu. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pacoxu
fix: check option['BinaryName'] for runtime absolute path
bcef864 
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
@djdongjin
Copy link
Member

djdongjin commented Mar 18, 2025

which version of containerd it's using? I believe we had a fix for this issue which is included in 2.0.3 #11442

@rata
Copy link
Contributor

rata commented Mar 18, 2025

@djdongjin awesome! This was hit in k8s e2e tests, it should be containerd 2.0.x (but kubernetes CI is not straight forward, not sure which patch release). @pacoxu do you understand with confidence which containerd version the tests are using?

@djdongjin any chance to backport that PR to the 2.0 branch?

@rata rata mentioned this pull request Mar 18, 2025
Closed
@djdongjin
Copy link
Member

djdongjin commented Mar 18, 2025

@djdongjin any chance to backport that PR to the 2.0 branch?

@rata oh yes it has been backported to 2.0 branch and released in 2.0.3 (backport PR #11446)

@dims dims mentioned this pull request Mar 18, 2025
Merged
@rata
Copy link
Contributor

rata commented Mar 18, 2025

Oh, great!

@pacoxu
Copy link
Contributor Author

pacoxu commented Mar 19, 2025 •
edited
Loading

@djdongjin Thanks for the information. We will try to bump containerd to v2.0.3+ then.

/close

@pacoxu pacoxu closed this Mar 19, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Pull Request Review Mar 19, 2025
@Iceber Iceber mentioned this pull request Mar 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/runtime Runtime kind/bug needs-ok-to-test size/S

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pacoxu @k8s-ci-robot @djdongjin @rata