Conversation
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
Kind of painful that CDI seems to rely on yaml v2 vs. v3 like the rest of containerd ecosystem. Wonder if we can get them to migrate to v3 so we don't have 2 complete versions of the yaml package imported. |
@estesp based on this comment they explicitly choose v2 to avoid introducing a new dep (cncf-tags/container-device-interface#236 (comment)) However it seems CDI already had both v2/v3 as indirect dependencies before that change (https://github.com/cncf-tags/container-device-interface/pull/236/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6L20-L21), and yaml v2 and v3 have the same dependencies: https://github.com/go-yaml/yaml/blob/v3.0.1/go.mod So my understanding is there shouldn't be difference for CDI to choose v3 or v2. Did I miss anything? @elezar |
|
yeah, I guess my comment was mostly that we now have another 10k lines of vendored code, with that being the addition of the entire v2 yaml project, while we already have v3 vendored. I'm not sure it's a huge deal, but I happened to notice it. |
AkihiroSuda
left a comment
There was a problem hiding this comment.
Having multiple YAML libraries is annoying, but probably not a blocker to merge this
@djdongjin that is correct. There should be no functional difference and we elected to stick with v2 at that stage because that was what was being imported by the Note that the v3 dependency is due to the We could look at released a We have created https://github.com/cncf-tags/container-device-interface/pull/262/files to switch to v3. |
Bumps [tags.cncf.io/container-device-interface](https://github.com/cncf-tags/container-device-interface) from 0.8.1 to 1.0.0. - [Release notes](https://github.com/cncf-tags/container-device-interface/releases) - [Changelog](https://github.com/cncf-tags/container-device-interface/blob/main/RELEASE.md) - [Commits](cncf-tags/container-device-interface@v0.8.1...v1.0.0) --- updated-dependencies: - dependency-name: tags.cncf.io/container-device-interface dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
f871c4d to
6670d41
Compare
Bumps tags.cncf.io/container-device-interface from 0.8.1 to 1.0.0.
Release notes
Sourced from tags.cncf.io/container-device-interface's releases.
Commits
40e4c31Merge pull request #260 from bart0sh/PR026-Bump-version-to-v1.0.06784e01Bump version to v1.0.0a097fb1Merge pull request #258 from elezar/document-release-process8aa91e1Add RELEASE.md with steps to create a release3a09dd0Merge pull request #257 from bart0sh/PR025-prepare-1.0.02a62da8Preparation for release 1.0.0012c8beMerge pull request #256 from klihub/fixes/codespell-release-branches842db48.github: run codespell for release branches, too.a582593Merge pull request #254 from klihub/fixes/refresh-sigsegv-with-nil-watcher1de2560pkg/cdi: add test case for post-EMFILE recovery.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)