Skip to content

[release/1.7 backport] cmd/ctr: allow user to syncfs during unpacking image locally#11305

Closed
tboevil wants to merge 1 commit intocontainerd:release/1.7from
tboevil:pick-ctr
Closed

[release/1.7 backport] cmd/ctr: allow user to syncfs during unpacking image locally#11305
tboevil wants to merge 1 commit intocontainerd:release/1.7from
tboevil:pick-ctr

Conversation

@tboevil
Copy link
Contributor

@tboevil tboevil commented Jan 23, 2025

@k8s-ci-robot
Copy link

k8s-ci-robot commented Jan 23, 2025

Hi @tboevil. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tboevil tboevil mentioned this pull request Jan 23, 2025
Merged
@tboevil tboevil changed the title [release/1.7 backport] pick #11118 [release/1.7 backport] cmd/ctr: allow user to syncfs during unpacking image locally Jan 23, 2025
@tboevil
cmd: add syncfs option to ctr command
273e498 
Signed-off-by: Qiyuan Liang <qiyuan.liang@smartx.com>
(cherry picked from commit 11b7825)
Signed-off-by: Qiyuan Liang <qiyuan.liang@smartx.com>
@novahe
Copy link

novahe commented Sep 1, 2025 •
edited
Loading

Kindly ping @tboevil, may I ask if any help is still needed for merging this PR?
When using ctr import to import an image with containerd 1.7.x, if the node loses power, the image contents are lost after the node restarts.

@ningmingxiao
Copy link
Contributor

ningmingxiao commented Sep 2, 2025 •
edited
Loading

you can enable global syncfs in containerd config

@novahe
Copy link

novahe commented Sep 3, 2025

you can enable global syncfs in containerd config

enable global syncfs in containerd config ？

@ningmingxiao
Copy link
Contributor

ningmingxiao commented Sep 4, 2025

[plugins.'io.containerd.service.v1.diff-service']
sync_fs = true @novahe

@novahe
Copy link

novahe commented Sep 5, 2025

@ningmingxiao thx

@tboevil
Copy link
Contributor Author

tboevil commented Sep 19, 2025

At present, I also use global configuration to solve the problem. This MR can be closed first and can be opened again at any time if needed later.

@tboevil tboevil closed this Sep 19, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Pull Request Review Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-ok-to-test size/M

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tboevil @k8s-ci-robot @novahe @ningmingxiao